DM-34866: Fix column being used for plot_CircAp12_sub_PSF_meas_sky_stars #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-34866
branch
from
1129fee
to
3d8b581
Compare
Any intended use for the "parameters" definitions are not being taken advantage of and led to an incorrect column to be used for one set of sky plots. The safest option for now is to get rid of the "parameters" in favor of explicitly listing the column name (this way it should be easier to spot the incorrect use of "i_ap09Flux" for a plot explicitly labeled as plot_CircAp12_* that is being fixed here).
laurenam
force-pushed
the
tickets/DM-34866
branch
from
3d8b581
to
f62f7f4
Compare
sr525
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.