Merge pull request #202 from lsst/tickets/DM-43522

DM-43522:Remove too large alert packet write to disk

python/lsst/ap/association/packageAlerts.py

@@ -82,6 +82,13 @@ class PackageAlertsConfig(pexConfig.Config):
         default=False,
     )
 
+    doWriteFailedAlerts = pexConfig.Field(
+        dtype=bool,
+        doc="If an alert cannot be sent when doProduceAlerts is set, "
+            "write it to disk for debugging purposes.",
+        default=False,
+    )
+
 
 class PackageAlertsTask(pipeBase.Task):
     """Tasks for packaging Dia and Pipelines data into Avro alert packages.
@@ -320,9 +327,11 @@ def produceAlerts(self, alerts, ccdVisitId):
 
             except KafkaException as e:
                 self.log.warning('Kafka error: {}, message was {} bytes'.format(e, sys.getsizeof(alertBytes)))
-                with open(os.path.join(self.config.alertWriteLocation,
-                                       f"{ccdVisitId}_{alert['alertId']}.avro"), "wb") as f:
-                    f.write(alertBytes)
+
+                if self.config.doWriteFailedAlerts:
+                    with open(os.path.join(self.config.alertWriteLocation,
+                                           f"{ccdVisitId}_{alert['alertId']}.avro"), "wb") as f:
+                        f.write(alertBytes)
 
         self.producer.flush()
 

tests/test_packageAlerts.py

@@ -440,7 +440,7 @@ def mock_produce(*args, **kwargs):
             else:
                 return
 
-        packConfig = PackageAlertsConfig(doProduceAlerts=True)
+        packConfig = PackageAlertsConfig(doProduceAlerts=True, doWriteFailedAlerts=True)
         packageAlerts = PackageAlertsTask(config=packConfig)
 
         patcher = patch("builtins.open")