DM-43522:Remove too large alert packet write to disk #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As writing failed alerts to disk is only used for debugging, it should not be on by default and instead a configuration should be set when we want to inspect the alerts.
kfindeisen
approved these changes
Mar 26, 2024
| @@ -82,6 +82,12 @@ class PackageAlertsConfig(pexConfig.Config): | |||
| default=False, | |||
| ) | |||
|
|
|||
| doWriteFailedAlerts = pexConfig.Field( | |||
| dtype=bool, | |||
| doc="Write alerts which fail to send to disk for debugging purposes.", | |||
There was a problem hiding this comment.
It's probably worth mentioning that this option is only used if doProduceAlerts, and is independent of doWriteAlerts.
There was a problem hiding this comment.
I find the wording a bit hard to parse; maybe:
Suggested change
| doc="Write alerts which fail to send to disk for debugging purposes.", | |
| doc="If an alert cannot be sent, write it to disk for debugging purposes.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As writing failed alerts to disk is only used for debugging, it should not be on by default and instead a configuration should be set when we want to inspect the alerts.