DM-40412: Add edge flag filtering to trailedSourceFilter.py #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add trailed flag to trailedSourceFilter and update the unit tests accordingly.
bsmartradio
force-pushed
the
tickets/DM-40412
branch
from
702b179
to
1f9babf
Compare
mrawls
reviewed
Oct 20, 2023
bsmartradio
force-pushed
the
tickets/DM-40412
branch
2 times, most recently
from
73b8fab
to
0addc20
Compare
If doTrailedResult does not come before diaObjects, then if there are no diaObjects but there are genuine sources that need filtering, they were not being filtered. The filter is moved earlier and then returns an altered diaSources catalog. If the filter is not run, it returns an empty dataframe similar to how matchedDiaSources can also be empty.
bsmartradio
force-pushed
the
tickets/DM-40412
branch
from
0addc20
to
e8c0241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that trailed sources which cross over into edge regions are flagged, add in a filter to trailedSourceFilter.py. Currently, this filter is far more aggressive than it should be as it counts trailed sources crossing over into nodata regions as edges. This will be fixed in a later commit.