Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40412: Add edge flag filtering to trailedSourceFilter.py #180

Merged
merged 2 commits into from
Oct 23, 2023
Merged

DM-40412: Add edge flag filtering to trailedSourceFilter.py #180

merged 2 commits into from
Oct 23, 2023

Commits on Oct 18, 2023

  1. Add trailed Flag and update unit tests 

    Add trailed flag to trailedSourceFilter and update the unit tests accordingly.
    @bsmartradio
    bsmartradio committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    e9b154b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Move trailed source filter before diaObject check 

    If doTrailedResult does not come before diaObjects, then if there are no diaObjects but there are genuine sources that need filtering, they were not being filtered. The filter is moved earlier and then returns an altered diaSources catalog. If the filter is not run, it returns an empty dataframe similar to how matchedDiaSources can also be empty.
    @bsmartradio
    bsmartradio committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e8c0241 View commit details
    Browse the repository at this point in the history