DM-43416: Migrate AP code to external APDB configs #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2024
isullivan
approved these changes
Apr 29, 2024
The test previously used timeMethod as a proxy for determining whether a mock was run, instead of just asking the mock. This roundabout approach was, in effect, testing timeMethod instead of DiaPipelineTask.
This commit also includes the doConfigureApdb flag, which selects between apdb and apdb_config_url.
The new doConfigureApdb flag is *not* deprecated, since the default is the old behavior and pipelines are expected to override it.
The only tests that still use db_url are those specifically testing compatibility with the old system.
Since the old unit tests used custom loaders, the migration required a substantial rewrite. However, the database query output can now be mocked directly.
kfindeisen
force-pushed
the
tickets/DM-43416
branch
from
4e20ce9
to
1f93d40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
DiaPipelineTaskto use new-style configs instead of a nestedApdbConfigfield, and updates the unit tests forTestTotalUnassociatedObjectsto reflect lsst/verify#124. It also does some simplification of the task's unit tests.