DM-43416: Migrate AP code to external APDB configs #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests were written before addClassCleanup was available.
This commit also includes the doReadMarker flag, which selects between an APDB connection and apdb_config_url.
The new doReadMarker flag is *not* deprecated, since the default is the old behavior and pipelines are expected to override it. Likewise, DirectApdbLoader is not deprecated because it must be constructed during ApdbMetricTask initialization.
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
ApdbMetricTaskto use new-style configs instead of aConfiginput connection (which becomes unparseable on lsst/ap_association#210). The connection is not deprecated, as the task still needs it for its original purpose (knowing that prerequisite PipelineTasks have finished).