DM-11747: Finalize AssociationTask for ap_verify #5
Conversation
| @@ -117,8 +86,8 @@ def run(self, dia_sources, exposure): | |||
| Input exposure metadata containing the bounding box for this | |||
| exposure. | |||
| """ | |||
| bbox = exposure.bbox | |||
| wcs = exposure.wcs | |||
| bbox = afwGeom.Box2D(exposure.getBBox()) | |||
There was a problem hiding this comment.
Can't this just be box = exposure.getBBox()? If not, please add a comment to explain.
There was a problem hiding this comment.
Needs to be a Box2D type as other Box's do not have the method getCenter.
| -1) | ||
|
|
||
| score_struct = dia_collection.score( | ||
| src_cat, afwGeom.Angle(1.0, units=afwGeom.arcseconds)) |
There was a problem hiding this comment.
Couldn't you just write 1.0*afwGeom.arcseconds?
tests/test_dia_collection.py
Outdated
| for src_idx in range(5): | ||
| # Our scores should be extremely close to 0 but not exactly so due | ||
| # to machine noise. | ||
| self.assertFalse(np.isfinite(score_struct.scores[src_idx])) |
There was a problem hiding this comment.
I'd recommend self.assertTrue(np.isinf(score_struct.scores[src_idx])), but this is also fine.
|
Hey @isullivan, I made the changes you requested and also wrapped the return of get_dia_object_ids in list(...). Hopefully this fixes the comparability. I'll test in python3 tomorrow (it currently passes on 2) but feel free to pull and test the code yourself and let me know. |
|
Tested the code on a python3 stack and it passes. Will now merge. |
Debugged test_associate_sources. Fixed a bug in dia_collection that indexed associated DIAObjects improperly.
Fixed a few bugs in assoc_db_sqlite and dia_collection as well. Added a few missing docstrings. Changed AssociationTask max_dist default back to 1.0. Removed indexer_id from minimal_dia_source_schema method. Forced typing for sqlite queries and afw.table calls.
Wrapped the output of DIAObjectCollection.get_object_ids as a list.
morriscb
force-pushed
the
tickets/DM-11747
branch
from
72c00f4
to
cabfc4d
Compare
No description provided.