Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11747: Finalize AssociationTask for ap_verify #5

Merged
merged 4 commits into from
Oct 3, 2017
Merged

DM-11747: Finalize AssociationTask for ap_verify #5

merged 4 commits into from
Oct 3, 2017

Commits on Oct 3, 2017

  1. Added first unittests for AssociationTask 

    Debugged test_associate_sources.

Fixed a bug in dia_collection that indexed associated DIAObjects
improperly.
    @morriscb
    morriscb committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    08d24ab View commit details
    Browse the repository at this point in the history

  2. Changed DIAObjectCollection to accept an empty list.

    @morriscb
    morriscb committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    b24c4a2 View commit details
    Browse the repository at this point in the history

  3. Finalized first version of AssociationTask. 

    Fixed a few bugs in assoc_db_sqlite and dia_collection as well.

Added a few missing docstrings.

Changed AssociationTask max_dist default back to 1.0.

Removed indexer_id from minimal_dia_source_schema method.

Forced typing for sqlite queries and afw.table calls.
    @morriscb
    morriscb committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    340717f View commit details
    Browse the repository at this point in the history

  4. Responded to reviewer. 

    Wrapped the output of DIAObjectCollection.get_object_ids as a list.
    @morriscb
    morriscb committed Oct 3, 2017
    Configuration menu
    Copy the full SHA
    cabfc4d View commit details
    Browse the repository at this point in the history