DM-21098: Isolate outdated Gen 3 methods in gen2tasks #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires lsst/verify@9828169 to let generic PpdbMetricTask tests use dicts.
natelust
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes tests of
adaptArgsAndRunandgetInputDatasetTypesfrom the metric test suite. These tests would have been broken by the Gen 3 migration, and testing their functionality is redundant because these methods should not be overloaded (following the changes in lsst/verify#55).The PR also simplifies some of the code for testing
TestTotalUnassociatedObjects, removing some special-casing. It must be merged together with lsst/verify#55, which makes supporting changes to the generic test code.