DM-21098: Isolate outdated Gen 3 methods in gen2tasks #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The override is responsible for handling outputDataId, but no existing PpdbMetricTask needs it. Following the rework of PipelineTask, adaptArgsAndRun should be confined to code in the lsst.verify.gen2tasks package.
natelust
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricTask's original API handled the task inputs using an emulation of the original Gen 3PipelineTaskAPI, on the assumption that it would streamline migration to Gen 3. Now that the Gen 3 API has changed, these methods are merely quirks of the Gen 2 implementation.This PR removes all references to
gen2tasks.MetricTask.adaptArgsAndRunandgen2tasks.MetricTask.getInputDatasetTypesoutside of thegen2taskspackage. This makes subtasks easy to migrate to Gen 3 again (except forPpdbMetricTask, which will require a specialization ofrunQuantumthat can't be tested yet).This PR also improves the test framework for
PpdbMetricTask.