DM-37622: changes for HSMshape as the default #129
Conversation
| import lsst.meas.extensions.shapeHSM | ||
| config.measurement.slots.psfShape = "ext_shapeHSM_HsmPsfMoments" | ||
| config.measurement.slots.shape = "ext_shapeHSM_HsmSourceMoments" | ||
| config.measurement.plugins.names |= ["ext_shapeHSM_HsmSourceMoments", "ext_shapeHSM_HsmPsfMoments"] |
There was a problem hiding this comment.
Why can't we make these changes in DetectAndMeasureConfig directly? It's a diffim-specific task, and we probably want its default config to be appropriate for measuring on difference images.
There was a problem hiding this comment.
Agreed; I've opened a PR for ip_diffim to do just that: lsst/ip_diffim#247
| import lsst.meas.extensions.shapeHSM | ||
| config.measurement.slots.psfShape = "ext_shapeHSM_HsmPsfMoments" | ||
| config.measurement.slots.shape = "ext_shapeHSM_HsmSourceMoments" | ||
| config.measurement.plugins.names |= ["ext_shapeHSM_HsmSourceMoments", "ext_shapeHSM_HsmPsfMoments"] |
There was a problem hiding this comment.
Same comment here: we should just set this in the Task Config setDefaults.
There was a problem hiding this comment.
Done in the ip_diffim PR. I'm probably going to just cancel/close this PR and delete the branch entirely without merging it.
|
We're going to do the changes in the setDefaults function for DetectAndMeasureConfig in detectAndMeasure.py, so we don't need this branch or PR now. |
No description provided.