Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-37622: make HSM shape the default in detectAndMeasure #247

Merged
merged 1 commit into from Feb 2, 2023

Conversation

kherner
Copy link
Contributor

@kherner kherner commented Jan 28, 2023

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin names don't mean anything to me, so I'll have to take your word for it. Just a style comment.

'base_LocalWcs']
'base_LocalWcs',
'ext_shapeHSM_HsmSourceMoments',
'ext_shapeHSM_HsmPsfMoments']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following would be more forward-compatible with future changes:

Suggested change
'ext_shapeHSM_HsmPsfMoments']
'ext_shapeHSM_HsmPsfMoments',
]

add meas_extensions_shapeHSM to required products

style cleanup
@kherner kherner merged commit 6c579da into main Feb 2, 2023
@kherner kherner deleted the tickets/DM-37622 branch February 2, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants