DM-42217: Incorporate ModelPackage Butler datasets into ap_verify #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rai-harshit
approved these changes
Jan 23, 2024
This task uses a pretrained model in the Butler to characterize diaSources. Aside from the model (a PrerequisiteInput), its inputs and outputs integrate naturally with detectAndMeasure and transformDiaSrcCat.
kfindeisen
force-pushed
the
tickets/DM-42217
branch
from
b955d88
to
843dcb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
rbClassifytoApPipeand its variant pipelines, now that we have a suitable model in the major repos of interest (/repo/mainand theap_verifydatasets).It also adds themsgargument to all input/output contracts, to make them a bit more user-friendly.