DM-42217: Incorporate ModelPackage Butler datasets into ap_verify #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rai-harshit
approved these changes
Jan 20, 2024
|
Sorry @rai-harshit, I overlooked a documentation change (added as aae0fff; it's a result of the data set changes rather than the move to |
kfindeisen
force-pushed
the
tickets/DM-42217
branch
from
8231d55
to
30ccb36
Compare
|
@rai-harshit, can you take a look at 30ccb36, since it represents significant new content on the PR? |
rai-harshit
reviewed
Feb 6, 2024
This change makes both pipelines logically coherent, and prevents the configuration for rbClassify or transformDiaSrcCat from being lost in instrument specializations.
rbClassifier_data is no longer needed to use ap_verify; individual data sets should either include the desired model themselves, or exclude the rbClassify task from their pipeline. This reverts commit ef2d57a.
kfindeisen
force-pushed
the
tickets/DM-42217
branch
from
30ccb36
to
513e61a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
ApVerify's definitions ofrbClassify, which were added toApPipeon lsst/ap_pipe#156. This change minimizes the degree to whichApVerifyredefines the AP pipeline instead of augmenting it, fixing a bug where the classifications did not make it into the finalDiaSourcetable (see DM-41147).sconsand/orstack-os-matrix)?ap_verify.pyon at least one of the standard datasets?For changes to metrics, the
print_metricvaluesscript fromlsst.verifywill be useful.