Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42419: Break up ApVerify into pure with- and without-fakes pipelines #163

Merged
merged 1 commit into from Feb 23, 2024

Conversation

kfindeisen
Copy link
Member

This PR removes the disruptive "WithFakes" suffixes from tasks in ApPipeWithFakes. It must be merged together with lsst/ap_verify#213.

Copy link
Contributor

@BrunoSanchez BrunoSanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Now that with- and without-fakes processing is cleanly separated
downstream in ApVerify, there's no chance of confusion as to which
task is which.
@kfindeisen kfindeisen merged commit bdf9955 into main Feb 23, 2024
2 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-42419 branch February 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants