DM-42419: Break up ApVerify into pure with- and without-fakes pipelines #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2024
BrunoSanchez
approved these changes
Feb 22, 2024
Timing is problematic in ApVerifyWithFakes, because the fakes add more work to catalog-type tasks, and with-fakes and no-fakes tasks cannot be usefully compared. Source count metrics are, of course, directly affected by fakes.
This change linearizes the pipeline at the cost of delegating all non-fakes metric to ApVerify.yaml.
Now that with- and without-fakes processing is cleanly separated, there's no chance of confusion as to which task is which.
kfindeisen
force-pushed
the
tickets/DM-42419
branch
from
4d33c50
to
bd58947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all unnecessary without-fakes processing from
ApVerifyWithFakes, and moves all metrics that are better measured without fakes toApVerify. With no more need to disambiguate, it also removes theWithFakessuffix from individual tasks inApVerifyWithFakes.sconsand/orstack-os-matrix)?ap_verify.pyon at least one of the standard datasets?For changes to metrics, the
print_metricvaluesscript fromlsst.verifywill be useful.