DM-42220: Incorporate ModelPackage Butler datasets into Prompt Processing #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now support rbClassify both in shared repos and in Prompt Processing, so there's no reason not to run it.
hsinfang
approved these changes
Feb 20, 2024
| class: lsst.ap.association.TransformDiaSourceCatalogTask | ||
| config: | ||
| # TODO: prompt_prototype does not yet support R/B analysis: DM-42220. | ||
| doIncludeReliability: False |
There was a problem hiding this comment.
Should pipelines/LSSTComCamSim/ApPipe.yaml be updated too, assuming the model can be added to /repo/ops-rehearsal-3-prep?
There was a problem hiding this comment.
In theory, yes. But everyone seemed skeptical that that was a good idea. I can add it now, or save it for a later issue after we've seen how it works on LATISS-prod...
There was a problem hiding this comment.
Leaving it for later is totally fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pre-emptive blocker that prevented
rbClassifyfrom being run in LATISS (specifically, Prompt Processing). It must be merged after lsst-dm/prompt_processing#125.