Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42220: Incorporate ModelPackage Butler datasets into Prompt Processing #164

Merged
merged 1 commit into from
Feb 21, 2024
Merged

DM-42220: Incorporate ModelPackage Butler datasets into Prompt Processing #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 0 additions & 10 deletions pipelines/LATISS/ApPipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,3 @@ description: |
instrument: lsst.obs.lsst.Latiss
imports:
- location: $AP_PIPE_DIR/pipelines/_ingredients/ApPipe.yaml
exclude:
# TODO: prompt_prototype does not yet support R/B analysis: DM-42220.
- rbClassify

tasks:
transformDiaSrcCat:
class: lsst.ap.association.TransformDiaSourceCatalogTask
config:
# TODO: prompt_prototype does not yet support R/B analysis: DM-42220.
doIncludeReliability: False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should pipelines/LSSTComCamSim/ApPipe.yaml be updated too, assuming the model can be added to /repo/ops-rehearsal-3-prep?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, yes. But everyone seemed skeptical that that was a good idea. I can add it now, or save it for a later issue after we've seen how it works on LATISS-prod...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it for later is totally fine