DM-43960: Spatial sample metrics task breaks fakes pipeline #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fakes pipeline contained an error where the task tried to read an initial_pvi instead of a calexp.
This tester checks that the pipeline isn't demanding any exotic inputs, independent of the contracts. This provides an extra layer of protection against mis-configuration.
isullivan
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Thank you for the fix! Two comments:
- If possible, please append something to identify which pipeline failed to the error message if
test_datasetsfails. - Our contracts are getting very long, and are mostly the same between
ApPipeandApPipeWithFakes. Is it possible to refactor out the common contracts to aApPipeContracts.yamlfile and import it? This would be a new ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a configuration bug in
ApPipeWithFakesand adds more extensive pipeline checks.This PR must be merged after lsst/pipe_base#414.