DM-43960: Make PipelineStepTester more flexible #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
changed the title
kfindeisen
force-pushed
the
tickets/DM-43960
branch
2 times, most recently
from
cbdbadd
to
2d0dd30
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 81.10% 80.99% -0.11%
==========================================
Files 93 93
Lines 10768 10780 +12
Branches 2056 2057 +1
==========================================
- Hits 8733 8731 -2
- Misses 1691 1704 +13
- Partials 344 345 +1 ☔ View full report in Codecov by Sentry. |
Prospective users should be able to understand how to use the class without having to read the code.
This parameter makes it possible to modify the pipeline read from the file if the file pipeline cannot be valid as-is.
The original output format assumed a non-empty suffix, but this leads to a confusing "()" if the full pipeline is tested at once.
kfindeisen
force-pushed
the
tickets/DM-43960
branch
from
7a65fdc
to
e264715
Compare
TallJimbo
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional config patcher to
PipelineStepTester, making it possible to run it onApPipeandApPipeWithFakes.Checklist
doc/changes