DM-26140: Standardize AP pipeline structure #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
Sep 29, 2021
|
I thought I managed to be consistent within a single file. If I need to standardize the files, then why two spaces instead of four? I'd find two spaces hard to read, especially for long blocks. |
|
We still need a "real" yaml style guide, don't we... I'm basing my interim 2-space assertion on what |
kfindeisen
force-pushed
the
tickets/DM-26140
branch
from
e2a9a19
to
5f9fd3e
Compare
natelust
approved these changes
Oct 5, 2021
This commit ensures all instruments have the same pipelines (so that a user or 3rd-party program need not guess), and has ApPipe and ApTemplate delegate all single-frame changes to ProcessCcd.
These subsets make it easier to refer to individual pipelines from within compositions.
This commit does not parameterize ProcessCcd.yaml (which would require adding a lot of config overrides that are currently absent) nor DarkEnergyCamera/ApPipe_hits2015-3.yaml (which is supposed to be a record of a specific pipeline run).
kfindeisen
force-pushed
the
tickets/DM-26140
branch
from
5f9fd3e
to
d2844c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the
ap_pipepipeline structure slightly to make it easier to call fromap_verify. The only functional change should be the creation of new subsets.