DM-26953: Update ap_verify system for calibration collections #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Oct 2, 2020
I tried to get around the messiness of the Gen 3 collections system by simply asking the Butler for all collections. However, now that calibration collections have been implemented, this picks up collections that weren't meant to be user-visible. Replace with a semi-hardcoded list.
kfindeisen
force-pushed
the
tickets/DM-26953
branch
from
b71ea26
to
d380c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
ap_verify's Butler interface more specific by replacing general "all collections" queries with a list of expected collections. Recent changes to calibration handling have added collections that should not be used for user input.