DM-40210: Clean up ap_pipe and ap_verify pipelines #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were overlooked on #186.
This config override was added in error because it's unused (processVisitFakes.calibrate should not be running photoCal at all).
This override turns out to be a hack for alert-broker support that has nothing to do with ap_verify, metrics, or testing. However, it will need to be fixed later because of scheduling constraints.
rbClassify is not instrument-specific, and should not be introduced in instrument pipelines; at present they also have no instrument-specific configs. They properly belong in ApPipe, but moving them there is impractical at present.
The modelPackageName override assumes that modelPackageStorageMode is left at its default of neighbor, which may cause trouble if the default changes. This way, the config will remain valid unless rbResnet50-DC2 itself moves.
rai-harshit
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the
rbClassifytask from instrument-specific pipelines to the base (_ingredients) pipeline and removes some configs that are redundant at the instrument level. This leaves the pipelines cleaner and with clearer responsibilities, and will prevent changes to the base pipeline from unexpectedly not working.Unfortunately, the
ApVerifypipeline still contains a few elements that should be inApPipebut that shouldn't be moved at this time. These have been marked with TODO comments.