DM-40210: Guard against future ap_pipe changes #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doSolarSystemAssociation must not be set because of how we mock up our HSC visits; there's no easy way to get something that could match.
rbClassify is not yet part of the root ApPipe.yaml, but we don't want to run it until we have appropriate support (either weights datasets in our central repos, or a copy of a weights package inside the container). This support will be added after we get R/B working for regular ApPipe runs.
The pipeline is included in the container, so pipeline changes may affect the service's behavior.
kfindeisen
force-pushed
the
tickets/DM-40210
branch
from
73ebfd4 to
953b3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an exclusion of the
rbClassifytask from the Prompt Processing pipeline, in case it is added toap_pipein the future (see comments added in lsst/ap_verify#196 for details on the blockers). This will prevent us from accidentally trying to run the task before we are ready for it.