Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40650: RBTransiNet runtime not being measured #202

Merged
merged 2 commits into from Sep 5, 2023
Merged

Conversation

kfindeisen
Copy link
Member

This PR adds a config fix to let *timing_rbClassify run in the Fakes pipeline.


  • Do unit tests pass (scons and/or stack-os-matrix)?
  • Did you run ap_verify.py on at least one of the standard datasets?
  • Is the Sphinx documentation up-to-date?

The task label for RBTransiNetTask is different for the two pipelines
(rbClassify vs. rbClassifyWithFakes), so the timing tasks need to be
configured appropriately.
print_metricvalues can be used to test whether metrics are working
correctly (e.g., being generated).
@kfindeisen kfindeisen changed the title Tickets/dm 40650 DM-40650: RBTransiNet runtime not being measured Sep 5, 2023
Copy link
Contributor

@kherner kherner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; sorry I missed that the task name was different in the fakes piepline.

@kfindeisen
Copy link
Member Author

Well, I missed it too!

@kfindeisen kfindeisen merged commit b4c42bc into main Sep 5, 2023
2 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-40650 branch September 5, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants