Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40650: RBTransiNet runtime not being measured #202

Merged
merged 2 commits into from
Sep 5, 2023
Merged

DM-40650: RBTransiNet runtime not being measured #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6abea3
Add timing task overrides to ApVerifyWithFakes.
kfindeisen Sep 5, 2023
09591df
Add a note about print_metricvalues to the PR checklist.
kfindeisen Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@

- [ ] Do unit tests pass (`scons` and/or `stack-os-matrix`)?
- [ ] Did you run `ap_verify.py` on at least one of [the standard datasets](https://pipelines.lsst.io/v/daily/modules/lsst.ap.verify/datasets.html#supported-datasets)?
For changes to metrics, the `print_metricvalues` script from `lsst.verify` will be useful.
- [ ] Is the Sphinx documentation up-to-date?
10 changes: 10 additions & 0 deletions pipelines/_ingredients/ApVerifyWithFakes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ tasks:
config:
connections.labelName: transformDiaSrcCatWithFakes # Default is transformDiaSrcCat
target: transformDiaSrcCatWithFakes.run
timing_rbClassify:
class: lsst.verify.tasks.commonMetrics.TimingMetricTask
config:
connections.labelName: rbClassifyWithFakes # Default is rbClassify
target: rbClassifyWithFakes.run
cputiming_rbClassify:
class: lsst.verify.tasks.commonMetrics.CpuTimingMetricTask
config:
connections.labelName: rbClassifyWithFakes # Default is rbClassify
target: rbClassifyWithFakes.run
subsets:
apPipe:
# Extend the subset through imageDifference.
Expand Down