DM-16535: Implement MetricRegistry #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that MetricsControllerTask is configurable, the timing information can be controlled from a config file instead of hard-coded.
kfindeisen
force-pushed
the
tickets/DM-16535
branch
from
b1417e0
to
6ab0779
Compare
parejkoj
reviewed
Jan 29, 2019
| "apPipe:differencer:subtract.subtractExposures": "ip_diffim.ImagePsfMatchTime", | ||
| "apPipe:differencer:detection.run": "meas_algorithms.SourceDetectionTime", | ||
| "apPipe:differencer:measurement.run": "ip_diffim.DipoleFitTime", | ||
| "apPipe:associator.run": "ap_association.AssociationTime", |
There was a problem hiding this comment.
It seems unfortunate that the names had to be lifted out of the yaml and stringified: makes it a bit harder to scan. But probably inevitable.
There was a problem hiding this comment.
I think this is a usability improvement overall, since "what do we want to run?" is something Stack users expect to live in a Python config file. The only real problem is that for verification we want to run a lot of tasks.
I've discussed the "lots of tasks" aspect with @TallJimbo and he said the Gen 3 framework will eventually support grouping pipeline tasks in some way. Hopefully that will, if not make config files simpler, at least let us segregate the parts that are and are not likely to change.
kfindeisen
force-pushed
the
tickets/DM-16535
branch
from
6ab0779
to
211e2f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration information required by
MetricsControllerTaskas of lsst/verify#33.