DM-16535: Implement MetricRegistry #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-16535
branch
2 times, most recently
from
dcfc87a
to
960a3b3
Compare
|
A variety of questions, most of which can probably be cleared up with revised documentation or added inline-comments in the code. Exactly how I hope you can move your Yay deleting code! |
parejkoj
reviewed
Jan 29, 2019
doc/lsst.verify/tasks/lsst.verify.compatibility.MetricsControllerTask.rst
Outdated
Show resolved
Hide resolved
doc/lsst.verify/tasks/lsst.verify.compatibility.MetricsControllerTask.rst
Outdated
Show resolved
Hide resolved
This commit removes most of the hardcoding from MetricsControllerTask.
This class was added in DM-16642, but I declined to document it because I thought it shouldn't be emphasized to the user. However, the framework for documenting subtasks (in this case, of MetricsControllerTask) requires that each default subtask have a task topic page and not just an API entry.
kfindeisen
force-pushed
the
tickets/DM-16535
branch
from
960a3b3
to
d851d09
Compare
kfindeisen
force-pushed
the
tickets/DM-16535
branch
from
d851d09
to
e293ec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds infrastructure to
lsst.verify.compatibilityfor configuringMetricTasks, and modifiesMetricsControllerTaskto use it. Since this change makesMetricsControllerTaskusable outside of carefully controlled environments, this PR also adds task documentation forMetricTaskandMetricsControllerTask.