DM-25407: ap_verify cannot handle curated crosstalk data in Gen 2 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2020
Merged
Merged
mrawls
approved these changes
Jun 12, 2020
kfindeisen
force-pushed
the
tickets/DM-25407
branch
from
dbd96f7
to
662f040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bulk removal of all references to "defects" in
DatasetIngestTask, removing some out-of-date documentation in the process. It then modifies the code to take a (possibly empty) list of curated calib directories, allowing more than one type of curated calib to be ingested at a time.I ended up sacrificing the code that guards against repeated ingestion of defects. It should be possible to make the check more generic (auto-detecting what the ingested files should look like), but I'm putting that off until DM-25414 to get things merged today.