Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-25407: ap_verify cannot handle curated crosstalk data in Gen 2 #156

Merged
merged 1 commit into from Jun 12, 2020

Conversation

kfindeisen
Copy link
Member

This PR edits datasetIngest.py for the changes made to DatasetIngestConfig in lsst/ap_verify#91, and adds crosstalk coefficients to the list of data products to be ingested.

@kfindeisen kfindeisen requested a review from mrawls June 12, 2020 22:14
Copy link
Contributor

@mrawls mrawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, but I suggest rebasing into a single commit since you presently do and undo some things in the existing 3 commits.

This specifically includes crosstalk, which was previously unsupported.
@kfindeisen kfindeisen merged commit 5cc2197 into master Jun 12, 2020
@kfindeisen kfindeisen deleted the tickets/DM-25407 branch June 12, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants