DM-19331: Add detector_unique_name property and fix Subaru names #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Apr 17, 2019
timj
commented
- HSC now has a detector group and uses the correct names of form N_MM
- SuprimeCam now uses the Miyazaki names
- Added detector_unique_name property and provide default implementation inherited by all translators.
SimonKrughoff
approved these changes
Apr 17, 2019
* Adds a basic implementation in the base class to allow it to be derived from other properties. * This required that StubTranslator and the property method maker check that a concrete translation method for a property has not been created.
Uses the Miyazaki names now.
* Define a detector group * Includes the mapping from detector number to name (currently exported from obs_subaur). * Defines an explicit to_detector_unique_name to reconstruct the common name.
S29 means group "S" detector "29". Unique name is now S29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.