Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-19331: Add detector_unique_name property and fix Subaru names #19

Merged
merged 7 commits into from
Apr 25, 2019
Merged

DM-19331: Add detector_unique_name property and fix Subaru names #19

merged 7 commits into from
Apr 25, 2019

Commits on Apr 17, 2019

  1. Add detector_unique_name property 

    * Adds a basic implementation in the base class to allow it to
  be derived from other properties.
* This required that StubTranslator and the property method
  maker check that a concrete translation method for a property
  has not been created.
    @timj
    timj committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    b1a866b View commit details
    Browse the repository at this point in the history

  2. Fix SuprimeCam detector name calculation 

    Uses the Miyazaki names now.
    @timj
    timj committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    9312ac2 View commit details
    Browse the repository at this point in the history

  3. Use the HSC names of form N_MM 

    * Define a detector group
* Includes the mapping from detector number to name (currently
  exported from obs_subaur).
* Defines an explicit to_detector_unique_name to reconstruct
  the common name.
    @timj
    timj committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    bf50dae View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Add detector group for DECam 

    S29 means group "S" detector "29". Unique name is now S29.
    @timj
    timj committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    f5320e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. CFHT users want the ccdNN names not the nick names

    @timj
    timj committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    dd5fb43 View commit details
    Browse the repository at this point in the history

  2. Try to clarify the description of detector_unique_name

    @timj
    timj committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    b6df1b6 View commit details
    Browse the repository at this point in the history

  3. Add docs URL to readme

    @timj
    timj committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    8d94a47 View commit details
    Browse the repository at this point in the history