DM-27350: Add ability to require mandatory translations and also a subset #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Oct 29, 2020
timj
commented
- This allows for more efficient translations if only a few properties are needed.
- This allows code to fail early if the result is required to include defined values for a property.
RobertLuptonTheGood
approved these changes
Oct 30, 2020
| If not `None`, controls the translations that will be performed | ||
| during construction. This can be useful if the caller is only | ||
| interested in a subset of the properties and knows that some of | ||
| the others might be slow to compute (which can be the case for |
There was a problem hiding this comment.
super-picky: "(e.g. the airmass if it has to be derived)"
| TypeError | ||
| Raised if the supplied translator class was not a MetadataTranslator. | ||
| KeyError | ||
| Raised if a translation fails and pedantic mode is enabled. | ||
| Raised if a translation fails and pedantic mode is enabled or if |
There was a problem hiding this comment.
Does this mean,
"Raised if a required property cannot be calculated, or if pedantic mode is enabled and any translation fails"
I had to read it twice.
| all_properties = set(self._PROPERTIES) | ||
| if subset is not None: | ||
| if not subset: | ||
| raise ValueError("Can not request no properties be calculated.") |
There was a problem hiding this comment.
"Cannot request that no properties be calculated"
* This allows for more efficient translations if only a few properties are needed. * This allows code to fail early if the result is required to include defined values for a property.
timj
force-pushed
the
tickets/DM-27350
branch
from
3236de3
to
0c866db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.