DM-27350: Define mandatory properties for ObservationInfo #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Demand up front that certain properties are calculable * Do not calculate properties that are not required for the registry schema
timj
force-pushed
the
tickets/DM-27350
branch
from
7fe581c
to
f299790
Compare
RobertLuptonTheGood
approved these changes
Oct 30, 2020
| # list here the properties we need for the schema | ||
| # Use a dict with values a boolean where True indicates | ||
| # that it is required that we calculate this property. | ||
| ingest_subset = { |
There was a problem hiding this comment.
Is this using a dict just for its hashing? Would a set work instead?
There was a problem hiding this comment.
A set is what we need in the end but I use a dict here so that I can specify the required keys here once without having to have a separate list of the properties to calculate and the required properties. You see a few lines below that I convert this dict into two sets for the ObservationInfo constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/astro_metadata_translator#42