DM-26696: Fixes to fix_header usage #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timj
commented
Oct 30, 2020
timj
commented
- Trap bad corrections yaml files
- Add filename and obsid to MetadataTranslator.fix_header class method
If a YAML corrections file exists but is not in the right format because it uses lists or only has a comment but no mapping, ignore it and warn.
This lets people use the information in log messages.
To give the option of including it in log messages.
timj
force-pushed
the
tickets/DM-26696
branch
from
b27556a
to
b725d6c
Compare
RobertLuptonTheGood
approved these changes
Nov 3, 2020
|
|
||
| def assertObservationInfo(self, header, check_wcs=True, wcs_params=None, **kwargs): # noqa: N802 | ||
| def assertObservationInfo(self, header, filename=None, check_wcs=True, # noqa: N802 |
There was a problem hiding this comment.
I'm being dense, but what's the N802 infraction here?
There was a problem hiding this comment.
It's a naming complaint. This package tries to use underscores but in this particular method it's matching the non-standard convention of unittest.TestCase.
This allows all translators to use the filename+obsid or obsid depending on the availability of the filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.