DM-26696: Support new fix_header API #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLuptonTheGood
approved these changes
Nov 3, 2020
| """ | ||
| modified = False | ||
|
|
||
| # Prefer filename to obsid for log messages | ||
| log_label = filename or obsid |
There was a problem hiding this comment.
Is this pattern documented? I might well have put both into the log message (I think your choice is fine)
There was a problem hiding this comment.
It's not documented because it's currently a decision specifically for this method. We could have a class method that is given the file and obsid and returns a consistent string. You are allowed to put both in but you have to handle the case where there is no file known so we could instead do something like
log_label = f"{filename}:{obsid}" if filename else obsidI'm fine either way.
There was a problem hiding this comment.
Following your comment above I have standardized this in a single method and switched all logging to use it. I did add the filename and obsid if filename is defined.
* Prefer filename over obsid
Now use a single method to calculate the prefix to use for log messages.
timj
force-pushed
the
tickets/DM-26696
branch
from
376a5a7
to
cee7db0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/astro_metadata_translator#43