DM-27477: Add JSON serialization for ObservationInfo #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now explicitly check to ensure that the types match.
This required addition of new helper functions in the properties definition. These are used to convert Astropy objects to simple form and to convert that simple form back to Astropy. Adding this made the __eq__ method much more robust since now the simplified forms are compared directly rather than comparing stringified forms.
timj
force-pushed
the
tickets/DM-27477
branch
3 times, most recently
from
9fc507b
to
5c01287
Compare
erykoff
approved these changes
Feb 16, 2021
| @@ -108,6 +108,9 @@ def __iter__(self): | |||
| def __eq__(self, other): | |||
| """Compares equal if all the members are equal in the same order. | |||
| """ | |||
| if not isinstance(other, ObservationGroup): | |||
| return NotImplemented | |||
There was a problem hiding this comment.
After looking into this, I have now learned about NotImplemented as a valid return for __eq__.
If both of them have nan then we treat that as equal.
timj
force-pushed
the
tickets/DM-27477
branch
from
947caa9
to
f084d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.