Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-27477: Add JSON serialization for ObservationInfo #48

Merged
merged 7 commits into from
Feb 17, 2021
Merged

DM-27477: Add JSON serialization for ObservationInfo #48

merged 7 commits into from
Feb 17, 2021

Commits on Feb 15, 2021

  1. Fix ObservationGroup __eq__ fallback mode 

    Now explicitly check to ensure that the types match.
    @timj
    timj committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    e65fc11 View commit details
    Browse the repository at this point in the history

  2. Fix error message to reflect single unrecognized vs many

    @timj
    timj committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    d04e70f View commit details
    Browse the repository at this point in the history

  3. Add ObservationInfo to_simple and from_simple methods 

    This required addition of new helper functions in the properties
definition. These are used to convert Astropy objects to simple
form and to convert that simple form back to Astropy.

Adding this made the __eq__ method much more robust since now
the simplified forms are compared directly rather than
comparing stringified forms.
    @timj
    timj committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    6471f72 View commit details
    Browse the repository at this point in the history

  4. Add ObservationGroup str test

    @timj
    timj committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    5955d06 View commit details
    Browse the repository at this point in the history

  5. Add ObservationGroup to/from_simple

    @timj
    timj committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    6dc88c5 View commit details
    Browse the repository at this point in the history

  6. Add JSON serialization for ObservationInfo

    @timj
    timj committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    5c01287 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Update ObservationInfo.__eq__ to handle NaN 

    If both of them have nan then we treat that as equal.
    @timj
    timj committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    f084d3e View commit details
    Browse the repository at this point in the history