DM-10281: compiler warnings in astshim #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
May 18, 2017
| @@ -1125,7 +1125,7 @@ class Frame : public Mapping { | |||
| axis order for output data). | |||
| */ | |||
| void permAxes(std::vector<int> perm) { | |||
| detail::assertEqual(static_cast<int>(perm.size()), "perm.size()", getNaxes(), "naxes"); | |||
| detail::assertEqual(perm.size(), "perm.size()", static_cast<std::size_t>(getNaxes()), "naxes"); | |||
There was a problem hiding this comment.
why is getNaxes() returning an int?
There was a problem hiding this comment.
Because AST itself uses an int (it has astGetI but not an unsigned variant). I consider unsigned ints a bit of a nuisance -- important if very large positive values are expected, but otherwise rarely worth the hassle. Note that much of the DM stack works the same way; for example Box.getArea, getWidth and getHeight all return int, despite the fact that they are never negative.
Fix gcc warnings: format not a string literal and no format arguments in calls to AST functions by specifying the format argument as `"%s"` and the data as `options.c_str()` (with thanks to Tim Jenness).
In some places assertEqual was called with (size_t, int) which led to compiler warnings. Fix those with static_cast<std::size_t> of the int argument. In one case the size_t argument was cast to int instead, but I changed it to match the rest of the code.
The previous two changes made some lines longer so reformat all C++ code with clang-format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.