Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10281: compiler warnings in astshim #15

Merged
merged 4 commits into from
May 18, 2017
Merged

DM-10281: compiler warnings in astshim #15

merged 4 commits into from
May 18, 2017

Commits on May 18, 2017

  1. Fix printf-related compiler warnings 

    Fix gcc warnings: format not a string literal and no format arguments
in calls to AST functions by specifying the format argument as `"%s"`
and the data as `options.c_str()` (with thanks to Tim Jenness).
    @r-owen
    r-owen committed May 18, 2017
    Configuration menu
    Copy the full SHA
    d91dd8b View commit details
    Browse the repository at this point in the history

  2. Add static_cast where needed for assertEqual 

    In some places assertEqual was called with (size_t, int)
which led to compiler warnings. Fix those with
static_cast<std::size_t> of the int argument.
In one case the size_t argument was cast to int instead,
but I changed it to match the rest of the code.
    @r-owen
    r-owen committed May 18, 2017
    Configuration menu
    Copy the full SHA
    d2dcd9d View commit details
    Browse the repository at this point in the history

  3. Reformat with clang-format 

    The previous two changes made some lines longer
so reformat all C++ code with clang-format.
    @r-owen
    r-owen committed May 18, 2017
    Configuration menu
    Copy the full SHA
    c32731d View commit details
    Browse the repository at this point in the history

  4. Add missing documentation for items in base.h

    @r-owen
    r-owen committed May 18, 2017
    Configuration menu
    Copy the full SHA
    099c320 View commit details
    Browse the repository at this point in the history