DM-10764: Rename Transform::of(first) and Mapping::of(first) to then(next)
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Jun 2, 2017
| @return a new CmpFrame | ||
| */ | ||
| CmpFrame over(Frame const &first) const; | ||
| CmpFrame under(Frame const &next) const; |
There was a problem hiding this comment.
Both names are kind of confusing. Isn't this operation X<1D> + Y<1D> -> XY<2D>? Something like "join" might be more suggestive than "under".
| # forward and inverse with a compound map of amap.getInverse().of(amap) | ||
| acmp = amapinv.of(amap) | ||
| # forward and inverse with a compound map of amap.then(amap.getInverse()) | ||
| acmp = amap.then(amapinv) |
Rename `Mapping.of` to `Mapping.then`, `Mapping.over` to `Mapping.under` and `Frame.over` to `Frame.under`, rename the argument from "first" to "next" and swap the order in which the two mappings or frames are combined. This was done to enhance code readability when mappings are named "xToY", e.g. `aToC = aToB.then(bToC)` It also matches the order of arguments to `ParallelMap`, `SeriesMap` and `CmpFrame`.
and swap the arguments, for consistency with `Mapping.then`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and
Mapping::over(first)andFrame::over(first)tounder(next), to improve readability and match the constructor order ofSeriesMap,ParallelMapandCmpFrame.