Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10764: Rename Transform::of(first) and Mapping::of(first) to then(next) #19

Merged
merged 2 commits into from
Jun 2, 2017
Merged

DM-10764: Rename Transform::of(first) and Mapping::of(first) to then(next) #19

merged 2 commits into from
Jun 2, 2017

Commits on Jun 2, 2017

  1. Swap order of compound mapping and frame methods 

    Rename `Mapping.of` to `Mapping.then`,
`Mapping.over` to `Mapping.under`
and `Frame.over` to `Frame.under`,
rename the argument from "first" to "next"
and swap the order in which the two mappings or frames
are combined.
This was done to enhance code readability when
mappings are named "xToY", e.g. `aToC = aToB.then(bToC)`
It also matches the order of arguments to `ParallelMap`,
`SeriesMap` and `CmpFrame`.
    @r-owen
    r-owen committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    71827e9 View commit details
    Browse the repository at this point in the history

  2. Rename function prepend to append 

    and swap the arguments, for consistency with `Mapping.then`
    @r-owen
    r-owen committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    1dcee5e View commit details
    Browse the repository at this point in the history