DM-13686: Saving a particular FrameSet as FITS-WCS causes a segfault #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a segfault when writing a particular FrameSet as FITS-WCS
for unit tests
parejkoj
reviewed
Mar 1, 2018
tests/test_channel.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| import astshim as ast | |||
| from astshim.test import MappingTestCase | |||
|
|
|||
| DataDir = os.path.join(os.path.dirname(__file__)) | |||
| DataDir = os.path.join(os.path.dirname(__file__), "data") | |||
There was a problem hiding this comment.
Is this really the standard approach? I thought one would want to put this in setUp or setUpClass?
There was a problem hiding this comment.
Fair enough. I'll change all three tests that use DataDir to set self.dataDir in setUp`
| """Test that a particular FrameSet will not segfault when | ||
| we attempt to write it to a FitsChan as FITS-WCS | ||
| """ | ||
| def readObjectFromShow(path): |
There was a problem hiding this comment.
Would this be a useful utility function to lift into astshim itself?
There was a problem hiding this comment.
Possibly, but I'm reluctant to expand the API without a clear need. I'd have to think more about the name, for one thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is in starlink_ast; this branch adds a unit test