Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-13686: Saving a particular FrameSet as FITS-WCS causes a segfault #40

Merged
merged 3 commits into from
Mar 1, 2018
Merged

DM-13686: Saving a particular FrameSet as FITS-WCS causes a segfault #40

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f416db2
Add a unit test for DM-13686
r-owen Mar 1, 2018
986fd15
Be consistent about using tests/data as DataDir
r-owen Mar 1, 2018
70f5f0a
Set test data dir in `setUp` instead of globals
r-owen Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import astshim as ast
from astshim.test import MappingTestCase

DataDir = os.path.join(os.path.dirname(__file__))
DataDir = os.path.join(os.path.dirname(__file__), "data")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the standard approach? I thought one would want to put this in setUp or setUpClass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I'll change all three tests that use DataDir to set self.dataDir in setUp`



class TestChannel(MappingTestCase):
Expand Down