Tickets/dm 20069 #13
Closed
Tickets/dm 20069 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
force-pushed
the
tickets/DM-20069
branch
from
7c6a259
to
755ac12
Compare
parejkoj
requested changes
Jul 12, 2019
|
Can you please sort out the title of the PR so that it matches the standard of "DM-20069: This PR does this"? |
jdswinbank
force-pushed
the
tickets/DM-20069
branch
from
755ac12
to
8e3c9bc
Compare
This provides a working task that takes pairs of visits specified on the command line, and shows how to run isr on them etc, so that the algorithmic details and plot making can be worked on more easily by Andres.
plazas
force-pushed
the
tickets/DM-20069
branch
from
8e3c9bc
to
e09c685
Compare
Changed code to comply with DM style Fixed bugs in ptc.py Add log-log axis to ptc plot fix flake8 errors in utils.py Fix eups config Start to generalize PTC fit to n-deg polynomial Add boostrap function to estimate fit errors test polynomial fit to PTC do error propagation in fitted parameters Add outlier rejection in PTC
plazas
force-pushed
the
tickets/DM-20069
branch
from
e09c685
to
2b75a6a
Compare
|
Closing this PR as it's stale. The comments so far have been address and merged on a different ticket, so making a new, clean PR for Andrés' changes for the PTC code. NB Do not delete this branch - the unmerged changes are going to come soon on a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate PTC from set of flat field pairs, calculate linearity and linearity residual