DM-29756: Automatic retry with larger memory #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleGower
approved these changes
Aug 30, 2021
mxk62
force-pushed
the
tickets/DM-29756
branch
2 times, most recently
from
1b49c8a
to
e9cc708
Compare
There are two default values for the number of retries in ctrl_bps: None (no retries) and 5 (when memory auto scaling is enabled). However, they were not set consistently. The first was set during creation of a generic workflow job the other in the HTCondor plugin. As the second default value is also supposed to be used by all plugins, I made changes to make ctrl_bps use in the same place, when creating a generic workflow job.
The ClassAd for determining if job was put on hold due to exceeding memory was covering all observed cases. Fixed it.
Besides setting the number of retries on a job level (in the job submission file) they were also set in DAGMan submission file. Fixed it.
mxk62
force-pushed
the
tickets/DM-29756
branch
from
e9cc708
to
0b7314d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.