DM-30977: Accumulate log messages per quantum and store in butler #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With debug enabled characterizeImage generates half a million log messages adding up to 500MB of JSON data. Accumulating in memory is not reasonable in that scenario. Therefore we now accumulate into a temp file and ingest that file when the quantum has completed.
andy-slac
approved these changes
Jul 26, 2021
This simplifies the logic for ensuring that logs are always written to the butler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on lsst/daf_butler#546 and lsst/pipe_base#193
Checklist
doc/changes