DM-30977: Add python log handler to store LogRecord as they come in #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DM-30996 will most likely add |
|
The new |
andy-slac
reviewed
Jul 13, 2021
timj
force-pushed
the
tickets/DM-30977
branch
2 times, most recently
from
91873c3
to
365f2ce
Compare
2 tasks
2 tasks
andy-slac
approved these changes
Jul 22, 2021
These records can then be serialized in butler datastore.
There is a question as to whether this should be attached to the main message, kept as a separate string, or stored separately as a list of strings. For now it is stored as a separate single string.
This can be used to directly stream LogRecords in JSON format.
Returning a new ButlerLogRecords instance.
One record per line rather than a single JSON model per file.
This makes it available to test code and to other users without having to limit reading to butler formatter.
Also unify the format detection code rather than repeating it in stream and byte handling.
timj
commented
Jul 23, 2021
timj
force-pushed
the
tickets/DM-30977
branch
3 times, most recently
from
d198762
to
772330e
Compare
When splitting a potentially enormous string we want to avoid creating a list with potentially millions of elements.
timj
force-pushed
the
tickets/DM-30977
branch
2 times, most recently
from
f45f25f
to
877e3f9
Compare
This allows other test code to use it and encapsulates the access to the _MDC private dict.
Only make ButlerLogRecords public by default since that is the type stored in datastore. Also rename JsonFormatter to JsonLogFormatter to avoid confusion with the datastore formatter of the same name.
This temporarily changes the MDC for logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These records can then be serialized in butler datastore. This is assuming that lsst/log#55 is merged which will also need changes in daf_butler for initializing logging such that we no longer forward everything to lsst.log. Will need changes to ctrl_mpexec as well.
Checklist
doc/changes