Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-33303: Tests for pipelines where Task and Butler disagree on DatasetType #161

Merged
merged 2 commits into from Jan 21, 2022

Conversation

timj
Copy link
Member

@timj timj commented Jan 20, 2022

Depends on lsst/daf_butler#635 and lsst/pipe_base#228

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor comments.

python/lsst/ctrl/mpexec/preExecInit.py Outdated Show resolved Hide resolved
python/lsst/ctrl/mpexec/preExecInit.py Outdated Show resolved Hide resolved
tests/test_simple_pipeline_executor.py Outdated Show resolved Hide resolved
If the dataset types differ, it might be that the storage
classes are different. If the storage classes are compatible
with each other continue.
Now that storage class conversion exists it is possible for
a Task to declare one dataset type and the registry to
use a different definition. Test that this works by
using a test Task that can be configured with different
outputs.
@timj timj merged commit 2b30ea6 into main Jan 21, 2022
@timj timj deleted the tickets/DM-33303 branch January 21, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants